Conversation
JPrevost
force-pushed
the
etd-667-71defaults
branch
from
47da2b9 to
c0d9f10
Compare
jazairi
approved these changes
Oct 8, 2025
Contributor
jazairi
left a comment
jazairi
left a comment
There was a problem hiding this comment.
Confirmed locally that this fixes the problem by running the test described in the PR description. Thanks for figuring out a long-standing problem!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One way to see this change:
t = Transfer.lastt.files_countt.unassigned_files_countIf everything is working as expected, both file counts should match the number of files you attached in the UI.
To see that this was fixed, revert line 98 in
app/models/transfer.rbtosave, restart your server and console and run the same test. You should get 0unassigned_files_countwhich is incorrect.https://mitlibraries.atlassian.net/browse/ETD-66
Requires database migrations?
NO
Includes new or updated dependencies?
NO